Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 55 56 +1
Lines 2656 2738 +82
Branches 452 445 -7
=========================================
+ Hits 2656 2738 +82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
IT WORRKKKS SOOO HAPPPYYY💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for C# events and resolves #179 (breaking).
The old hack with transmuting C# methods with specific name patterns into JS events is removed: you can use normal C# events with the supported delegate types (
Action<>,EventHandler<>or any custom delegate without a return type) on both imported and exported APIs and they will cleanly materialize asEvent<>on the JS side.This also removes implicit references to the internal types, which allowed to remove the dynamic dependencies wiring, resulting is smaller build sizes.